* [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0
@ 2020-06-04 6:35 Manivannan Sadhasivam
2020-06-10 2:25 ` Martin K. Petersen
2020-06-10 3:35 ` Alim Akhtar
0 siblings, 2 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2020-06-04 6:35 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, linux-arm-msm, amit.kucheria,
Manivannan Sadhasivam
UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
adding it to the list of supported versions.
I don't have the exact information of the additional registers supported
in version 3.0. Hence the change just adds 0x300 to the list of supported
versions to remove the below warning:
"ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/scsi/ufs/ufshci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
index c2961d37cc1c..f2ee81669b00 100644
--- a/drivers/scsi/ufs/ufshci.h
+++ b/drivers/scsi/ufs/ufshci.h
@@ -104,6 +104,7 @@ enum {
UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
+ UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
};
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0
2020-06-04 6:35 [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0 Manivannan Sadhasivam
@ 2020-06-10 2:25 ` Martin K. Petersen
2020-06-10 7:34 ` Avri Altman
2020-06-10 3:35 ` Alim Akhtar
1 sibling, 1 reply; 4+ messages in thread
From: Martin K. Petersen @ 2020-06-10 2:25 UTC (permalink / raw)
To: avri.altman
Cc: Manivannan Sadhasivam, alim.akhtar, jejb, martin.petersen,
linux-scsi, linux-kernel, linux-arm-msm, amit.kucheria
Avri: Please review!
> UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> adding it to the list of supported versions.
>
> I don't have the exact information of the additional registers supported
> in version 3.0. Hence the change just adds 0x300 to the list of supported
> versions to remove the below warning:
>
> "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/scsi/ufs/ufshci.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> index c2961d37cc1c..f2ee81669b00 100644
> --- a/drivers/scsi/ufs/ufshci.h
> +++ b/drivers/scsi/ufs/ufshci.h
> @@ -104,6 +104,7 @@ enum {
> UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
> UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
> UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> + UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
> };
>
> /*
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0
2020-06-10 2:25 ` Martin K. Petersen
@ 2020-06-10 7:34 ` Avri Altman
0 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2020-06-10 7:34 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Manivannan Sadhasivam, alim.akhtar@samsung.com,
jejb@linux.ibm.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
amit.kucheria@linaro.org
>
> Avri: Please review!
>
> > UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> > adding it to the list of supported versions.
> >
> > I don't have the exact information of the additional registers supported
> > in version 3.0. Hence the change just adds 0x300 to the list of supported
> > versions to remove the below warning:
> >
> > "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
> >
> > Signed-off-by: Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org>
Already Nacked by Christoph.
Thanks,
Avri
> > ---
> > drivers/scsi/ufs/ufshci.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> > index c2961d37cc1c..f2ee81669b00 100644
> > --- a/drivers/scsi/ufs/ufshci.h
> > +++ b/drivers/scsi/ufs/ufshci.h
> > @@ -104,6 +104,7 @@ enum {
> > UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
> > UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
> > UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> > + UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
> > };
> >
> > /*
>
> --
> Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0
2020-06-04 6:35 [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0 Manivannan Sadhasivam
2020-06-10 2:25 ` Martin K. Petersen
@ 2020-06-10 3:35 ` Alim Akhtar
1 sibling, 0 replies; 4+ messages in thread
From: Alim Akhtar @ 2020-06-10 3:35 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Alim Akhtar, Avri Altman, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, open list, linux-arm-msm,
amit.kucheria
HI Manivannan
On Thu, Jun 4, 2020 at 12:08 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> UFS HCI 3.0 versions are being used in Qcom SM8250 based boards. Hence,
> adding it to the list of supported versions.
>
> I don't have the exact information of the additional registers supported
> in version 3.0. Hence the change just adds 0x300 to the list of supported
> versions to remove the below warning:
>
> "ufshcd-qcom 1d84000.ufshc: invalid UFS version 0x300"
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/scsi/ufs/ufshci.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h
> index c2961d37cc1c..f2ee81669b00 100644
> --- a/drivers/scsi/ufs/ufshci.h
> +++ b/drivers/scsi/ufs/ufshci.h
> @@ -104,6 +104,7 @@ enum {
> UFSHCI_VERSION_11 = 0x00010100, /* 1.1 */
> UFSHCI_VERSION_20 = 0x00000200, /* 2.0 */
> UFSHCI_VERSION_21 = 0x00000210, /* 2.1 */
> + UFSHCI_VERSION_30 = 0x00000300, /* 3.0 */
See the current discussion on this https://lkml.org/lkml/2020/4/27/192
> };
>
> /*
> --
> 2.17.1
>
--
Regards,
Alim
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-10 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-04 6:35 [PATCH] scsi: ufs: Bump supported UFS HCI version to 3.0 Manivannan Sadhasivam
2020-06-10 2:25 ` Martin K. Petersen
2020-06-10 7:34 ` Avri Altman
2020-06-10 3:35 ` Alim Akhtar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox