* [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() [not found] ` <20200411001933.10072-1-jbi.octave@gmail.com> @ 2020-04-11 0:19 ` Jules Irenge 2020-04-14 7:35 ` John Garry 2020-04-15 1:44 ` Martin K. Petersen 2020-04-11 0:19 ` [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() Jules Irenge 1 sibling, 2 replies; 5+ messages in thread From: Jules Irenge @ 2020-04-11 0:19 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, James E.J. Bottomley, Martin K. Petersen, John Garry, Allison Randal, Hannes Reinecke, Thomas Gleixner, open list:SCSI SUBSYSTEM Sparse reports a warning at sas_ata_qc_issue() warning: context imbalance in sas_ata_qc_issue() - unexpected unlock The root cause is the missing annotation at sas_ata_qc_issue() Add the missing __must_hold(ap->lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/scsi/libsas/sas_ata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index c5a828a041e0..5d716d388707 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -160,6 +160,7 @@ static void sas_ata_task_done(struct sas_task *task) } static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) + __must_hold(ap->lock) { struct sas_task *task; struct scatterlist *sg; -- 2.24.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() 2020-04-11 0:19 ` [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() Jules Irenge @ 2020-04-14 7:35 ` John Garry 2020-04-15 1:44 ` Martin K. Petersen 1 sibling, 0 replies; 5+ messages in thread From: John Garry @ 2020-04-14 7:35 UTC (permalink / raw) To: Jules Irenge, linux-kernel Cc: boqun.feng, James E.J. Bottomley, Martin K. Petersen, Allison Randal, Hannes Reinecke, Thomas Gleixner, open list:SCSI SUBSYSTEM, Jason Yan On 11/04/2020 01:19, Jules Irenge wrote: > Sparse reports a warning at sas_ata_qc_issue() > > warning: context imbalance in sas_ata_qc_issue() - unexpected unlock > The root cause is the missing annotation at sas_ata_qc_issue() > > Add the missing __must_hold(ap->lock) annotation > > Signed-off-by: Jules Irenge <jbi.octave@gmail.com> that looks ok... Reviewed-by: John Garry <john.garry@huawei.com> > --- > drivers/scsi/libsas/sas_ata.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c > index c5a828a041e0..5d716d388707 100644 > --- a/drivers/scsi/libsas/sas_ata.c > +++ b/drivers/scsi/libsas/sas_ata.c > @@ -160,6 +160,7 @@ static void sas_ata_task_done(struct sas_task *task) > } > > static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) > + __must_hold(ap->lock) > { > struct sas_task *task; > struct scatterlist *sg; > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() 2020-04-11 0:19 ` [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() Jules Irenge 2020-04-14 7:35 ` John Garry @ 2020-04-15 1:44 ` Martin K. Petersen 1 sibling, 0 replies; 5+ messages in thread From: Martin K. Petersen @ 2020-04-15 1:44 UTC (permalink / raw) To: Jules Irenge Cc: linux-kernel, boqun.feng, James E.J. Bottomley, Martin K. Petersen, John Garry, Allison Randal, Hannes Reinecke, Thomas Gleixner, open list:SCSI SUBSYSTEM Jules, > Sparse reports a warning at sas_ata_qc_issue() > > warning: context imbalance in sas_ata_qc_issue() - unexpected unlock > The root cause is the missing annotation at sas_ata_qc_issue() > > Add the missing __must_hold(ap->lock) annotation Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() [not found] ` <20200411001933.10072-1-jbi.octave@gmail.com> 2020-04-11 0:19 ` [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() Jules Irenge @ 2020-04-11 0:19 ` Jules Irenge 2020-04-24 16:56 ` Martin K. Petersen 1 sibling, 1 reply; 5+ messages in thread From: Jules Irenge @ 2020-04-11 0:19 UTC (permalink / raw) To: linux-kernel Cc: boqun.feng, supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER, James E.J. Bottomley, Martin K. Petersen, open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER Sparse reports a warning at bnx2fc_abts_cleanup() warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock The root cause is the missing annotation at bnx2fc_abts_cleanup() Add the missing __must_hold(&tgt->tgt_lock) annotation Signed-off-by: Jules Irenge <jbi.octave@gmail.com> --- drivers/scsi/bnx2fc/bnx2fc_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 4c8122a82322..b45f40db9379 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c @@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) } static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) + __must_hold(&tgt->tgt_lock) { struct bnx2fc_rport *tgt = io_req->tgt; unsigned int time_left; -- 2.24.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() 2020-04-11 0:19 ` [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() Jules Irenge @ 2020-04-24 16:56 ` Martin K. Petersen 0 siblings, 0 replies; 5+ messages in thread From: Martin K. Petersen @ 2020-04-24 16:56 UTC (permalink / raw) To: Jules Irenge Cc: linux-kernel, boqun.feng, supporter:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER, James E.J. Bottomley, Martin K. Petersen, open list:BROADCOM BNX2FC 10 GIGABIT FCOE DRIVER Jules, > Sparse reports a warning at bnx2fc_abts_cleanup() > > warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock > > The root cause is the missing annotation at bnx2fc_abts_cleanup() > > Add the missing __must_hold(&tgt->tgt_lock) annotation Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-24 16:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0/9>
[not found] ` <20200411001933.10072-1-jbi.octave@gmail.com>
2020-04-11 0:19 ` [PATCH 6/9] scsi: libsas: Add missing annotation for sas_ata_qc_issue() Jules Irenge
2020-04-14 7:35 ` John Garry
2020-04-15 1:44 ` Martin K. Petersen
2020-04-11 0:19 ` [PATCH 7/9] scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() Jules Irenge
2020-04-24 16:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).