linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: dgilbert@interlog.com, Randall Huang <ihhuang@abmail.org>,
	Christoph Hellwig <hch@infradead.org>,
	huangrandall@google.com, jejb@linux.vnet.ibm.com,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: associate bio write hint with WRITE CDB
Date: Thu, 03 Jan 2019 23:57:38 -0500	[thread overview]
Message-ID: <yq1ef9t81fh.fsf@oracle.com> (raw)
In-Reply-To: <6152b478ea77dacf57eef6f758ba795f756cd3da.camel@redhat.com> (Ewan D. Milne's message of "Thu, 03 Jan 2019 16:40:41 -0500")


Ewan,

> SBC-5 says that support for the grouping function is indicated by the
> GROUP_SUP bit in the Extended Inquiry VPD page (86h).  I'm not sure
> how many devices actually support that page though.  Probably most
> don't.

Several devices support it, albeit for various different purposes. It's
one of these wonderful features whose interpretation was left outside
the scope of the spec for a long time.

So even though we absolutely and positively need to make setting GROUP
NUMBER conditional on GROUP_SUP being reported, we also need additional
information from the storage about how the field should be interpreted.

The official way to report hinting is for the device to implement the IO
Advice Hints Grouping mode page. I wrote some code to support that but
no vendors that I know of ended up actually shipping an implementation.
A few implemented my older I/O class proposal but didn't ship that
either despite really convincing performance results.

If Randall has access to a device which implements hinting, I'd love to
know more.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-01-04  4:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181226041504.66283-1-huangrandall@google.com>
     [not found] ` <20190103075133.GA5141@infradead.org>
2019-01-03  9:47   ` [PATCH] scsi: associate bio write hint with WRITE CDB Randall Huang
2019-01-03 21:00     ` Douglas Gilbert
2019-01-03 21:40       ` Ewan D. Milne
2019-01-04  4:57         ` Martin K. Petersen [this message]
2019-01-04  5:22           ` Randall Huang
2019-01-04  6:11             ` Martin K. Petersen
2019-01-10 17:33             ` Alex Lemberg
2019-01-03  9:55 Randall Huang
  -- strict thread matches above, loose matches on Subject: below --
2019-01-03  9:19 Randall Huang
2018-12-26  5:51 Randall Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ef9t81fh.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=dgilbert@interlog.com \
    --cc=emilne@redhat.com \
    --cc=hch@infradead.org \
    --cc=huangrandall@google.com \
    --cc=ihhuang@abmail.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).