* [PATCH] lpfc: fix "integer constant too large" error on 32bit archs
@ 2017-07-27 12:33 Maurizio Lombardi
2017-07-27 12:57 ` Martin K. Petersen
0 siblings, 1 reply; 3+ messages in thread
From: Maurizio Lombardi @ 2017-07-27 12:33 UTC (permalink / raw)
To: james.smart; +Cc: dick.kennedy, jejb, martin.petersen, linux-scsi
cc1: warnings being treated as errors
drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn':
drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for 'long' type
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/scsi/lpfc/lpfc_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 491aa95..e992dc1 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -3710,8 +3710,8 @@
if (phba->sli_rev == LPFC_SLI_REV4)
return be64_to_cpu(wwn);
else
- return (((wwn & 0xffffffff00000000) >> 32) |
- ((wwn & 0x00000000ffffffff) << 32));
+ return (((wwn & 0xffffffff00000000ULL) >> 32) |
+ ((wwn & 0x00000000ffffffffULL) << 32));
}
--
Maurizio Lombardi
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: fix "integer constant too large" error on 32bit archs
2017-07-27 12:33 [PATCH] lpfc: fix "integer constant too large" error on 32bit archs Maurizio Lombardi
@ 2017-07-27 12:57 ` Martin K. Petersen
2017-07-27 14:50 ` Maurizio Lombardi
0 siblings, 1 reply; 3+ messages in thread
From: Martin K. Petersen @ 2017-07-27 12:57 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi
Maurizio,
> cc1: warnings being treated as errors
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_get_wwpn':
> drivers/scsi/lpfc/lpfc_init.c:3253: error: integer constant is too large for 'long' type
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 491aa95..e992dc1 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -3710,8 +3710,8 @@
> if (phba->sli_rev == LPFC_SLI_REV4)
> return be64_to_cpu(wwn);
> else
> - return (((wwn & 0xffffffff00000000) >> 32) |
> - ((wwn & 0x00000000ffffffff) << 32));
> + return (((wwn & 0xffffffff00000000ULL) >> 32) |
> + ((wwn & 0x00000000ffffffffULL) << 32));
rol64()?
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: fix "integer constant too large" error on 32bit archs
2017-07-27 12:57 ` Martin K. Petersen
@ 2017-07-27 14:50 ` Maurizio Lombardi
0 siblings, 0 replies; 3+ messages in thread
From: Maurizio Lombardi @ 2017-07-27 14:50 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: james.smart, dick.kennedy, jejb, linux-scsi
Dne 27.7.2017 v 14:57 Martin K. Petersen napsal(a):
>> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
>> index 491aa95..e992dc1 100644
>> --- a/drivers/scsi/lpfc/lpfc_init.c
>> +++ b/drivers/scsi/lpfc/lpfc_init.c
>> @@ -3710,8 +3710,8 @@
>> if (phba->sli_rev == LPFC_SLI_REV4)
>> return be64_to_cpu(wwn);
>> else
>> - return (((wwn & 0xffffffff00000000) >> 32) |
>> - ((wwn & 0x00000000ffffffff) << 32));
>> + return (((wwn & 0xffffffff00000000ULL) >> 32) |
>> + ((wwn & 0x00000000ffffffffULL) << 32));
>
> rol64()?
>
Right,
I will send a new version.
Maurizio
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-27 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-27 12:33 [PATCH] lpfc: fix "integer constant too large" error on 32bit archs Maurizio Lombardi
2017-07-27 12:57 ` Martin K. Petersen
2017-07-27 14:50 ` Maurizio Lombardi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox