From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, Meelis Roos <meelis.roos@ut.ee>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: scsi: only re-lock door after EH on devices that were reset
Date: Tue, 04 Nov 2014 20:57:59 -0500 [thread overview]
Message-ID: <yq1fvdyh0ig.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20141103183640.GA6718@lst.de> (Christoph Hellwig's message of "Mon, 3 Nov 2014 19:36:40 +0100")
>>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:
Christoph> Setups that use the blk-mq I/O path can lock up if a host
Christoph> with a single device that has its door locked enters EH.
Christoph> Make sure to only send the command to re-lock the door to
Christoph> devices that actually were reset and thus might have lost
Christoph> their state. Otherwise the EH code might be get blocked on
Christoph> blk_get_request as all requests for non-reset devices might
Christoph> be in use.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2014-11-05 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 18:36 scsi: only re-lock door after EH on devices that were reset Christoph Hellwig
2014-11-05 1:57 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fvdyh0ig.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=meelis.roos@ut.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox