From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anil kumar <anils_r@yahoo.com>
Cc: Christof Schmitt <christof.schmitt@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: scsi_cmnd data_buffer checksum
Date: Thu, 09 Sep 2010 09:23:24 -0400 [thread overview]
Message-ID: <yq1fwxjt5ir.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <215508.92384.qm@web32402.mail.mud.yahoo.com> (Anil kumar's message of "Thu, 9 Sep 2010 02:09:28 -0700 (PDT)")
>>>>> "Anil" == Anil kumar <anils_r@yahoo.com> writes:
Anil> cmd-> write_buf = (u8 *)(kmap_atomic(sg->page, KM_IRQ0) + sg->offset);
Anil> memcpy(cmd->local_write_buf, cmd->write_buf, cmd->scsibufflen(scsi_cmnd));
You need to walk the scatterlist. You can't assume that the pages are
contiguous in memory.
But why are you doing this checksumming stuff manually when the existing
DIX/DIF code can do it for you?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-09-09 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 3:36 scsi_cmnd data_buffer checksum Anil kumar
2010-09-09 8:00 ` Christof Schmitt
2010-09-09 8:35 ` Anil kumar
2010-09-09 8:51 ` Christof Schmitt
2010-09-09 9:09 ` Anil kumar
2010-09-09 9:29 ` Christof Schmitt
2010-09-09 13:23 ` Martin K. Petersen [this message]
2010-09-09 19:34 ` Anil kumar
2010-09-10 3:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fwxjt5ir.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=anils_r@yahoo.com \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox