From: "Martin K. Petersen" <mkp@kernel.org>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>
Cc: mkp@kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, john.garry@linux.dev, ddiss@suse.de,
hexlabsecurity@proton.me
Subject: Re: [PATCH v2] scsi: target: Verify the iSCSI ISID is NUL-terminated
Date: Fri, 30 Oct 2026 21:20:30 -0400 [thread overview]
Message-ID: <yq1h5i23bvm.fsf@mail.kernel.org> (raw)
In-Reply-To: <20261026124138.2708365-1-xiangzao@linux.alibaba.com>
Yuanhe,
> iscsi_parse_pr_out_transport_id() returns the ISID of a FORMAT CODE
> 01b TransportID as a pointer into the PERSISTENT RESERVE OUT parameter
> list, lowercased in place and never NUL-terminated. spc4r37 Table 508
> requires the field to be null-terminated, but a non-conforming
> initiator can omit the NUL; when the ISID ends at the end of the
> received buffer, the pointer is not a C string.
Applied to 7.4/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-10-31 1:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 4:46 [PATCH] scsi: target: Verify the iSCSI ISID is NUL-terminated Yuanhe Shu
2026-10-26 9:19 ` sashiko-bot
2026-10-26 12:48 ` Yuanhe Shu
2026-10-26 12:41 ` [PATCH v2] " Yuanhe Shu
2026-10-31 1:20 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h5i23bvm.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=ddiss@suse.de \
--cc=hexlabsecurity@proton.me \
--cc=john.garry@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=xiangzao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox