From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Brian Bunker <brian@purestorage.com>
Cc: linux-scsi@vger.kernel.org,
Seamus Connor <sconnor@purestorage.com>,
Krishna Kant <krishna.kant@purestorage.com>
Subject: Re: [PATCH] scsi: sd: Avoid sending an INQUIRY if the page is not supported
Date: Mon, 08 May 2023 08:26:01 -0400 [thread overview]
Message-ID: <yq1h6sn10by.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230505204950.21645-1-brian@purestorage.com> (Brian Bunker's message of "Fri, 5 May 2023 13:49:50 -0700")
Brian,
> When SCSI devices are discovered the function sd_read_cpr gets called.
> This call results in an INQUIRY to page 0xb9. This VPD page is called
> regardless of whether the target has advertised this page as
> supported.
We used to check the page list first. However, we found several devices
that we did not discover correctly because the pages, while present,
were not advertised in page 0 and thus ignored. So not checking the
supported pages first is a feature.
What exactly is the problem you are experiencing wrt. your target
getting an inquiry for the CPR page?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-05-08 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 20:49 [PATCH] scsi: sd: Avoid sending an INQUIRY if the page is not supported Brian Bunker
2023-05-08 10:09 ` Benjamin Block
2023-05-08 16:34 ` Brian Bunker
2023-05-11 16:44 ` Benjamin Block
2023-05-12 2:58 ` Douglas Gilbert
2023-05-08 12:26 ` Martin K. Petersen [this message]
2023-05-08 16:04 ` Brian Bunker
2023-05-10 14:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h6sn10by.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brian@purestorage.com \
--cc=krishna.kant@purestorage.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sconnor@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox