From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Cc: linux-scsi@vger.kernel.org, kashyap.desai@broadcom.com,
sumit.saxena@broadcom.com, kiran-kumar.kasturi@broadcom.com,
sankar.patra@broadcom.com, sasikumar.pc@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
anand.lodnoor@broadcom.com
Subject: Re: [PATCH] megaraid_sas: unique names for MSIx vectors
Date: Mon, 30 Sep 2019 23:43:38 -0400 [thread overview]
Message-ID: <yq1h84tw2ol.fsf@oracle.com> (raw)
In-Reply-To: <20190913065515.22493-1-chandrakanth.patil@broadcom.com> (Chandrakanth Patil's message of "Fri, 13 Sep 2019 12:25:15 +0530")
Chandrakanth,
> +#define MEGASAS_MSIX_NAME_LEN 16
[...]
> + snprintf(instance->irq_context[i].name, MEGASAS_MSIX_NAME_LEN, "%s%d-msix%d",
> + "megasas", instance->host->host_no, i);
Seems like MEGASAS_MSIX_NAME_LEN is too small given that naming scheme?
Also, please use %u.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-10-01 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 6:55 [PATCH] megaraid_sas: unique names for MSIx vectors Chandrakanth Patil
2019-10-01 3:43 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h84tw2ol.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=anand.lodnoor@broadcom.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=kiran-kumar.kasturi@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sankar.patra@broadcom.com \
--cc=sasikumar.pc@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).