From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: advansys: fix uninitialized data access Date: Tue, 04 Apr 2017 19:40:27 -0400 Message-ID: References: <20170323150226.249217-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20170323150226.249217-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 23 Mar 2017 16:02:18 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Matthew Wilcox , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Arnd Bergmann writes: Arnd, > drivers/scsi/advansys.c: In function 'AscMsgOutSDTR': > drivers/scsi/advansys.c:3860:26: error: '*((void *)&sdtr_buf+5)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > ((ushort)s_buffer[i + 1] << 8) | s_buffer[i]); > ^ > drivers/scsi/advansys.c:3860:26: error: '*((void *)&sdtr_buf+7)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > drivers/scsi/advansys.c:3860:26: error: '*((void *)&sdtr_buf+5)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > drivers/scsi/advansys.c:3860:26: error: '*((void *)&sdtr_buf+7)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The code has existed in this exact form at least since v2.6.12, and the > warning seems correct. This uses named initializers to ensure we initialize > all members of the structure. > (uchar *)&sdtr_buf, Applied to 4.12/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering