public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ben Collins <ben.c@servergy.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Neela Syam Kolli <megaraidlinux@lsi.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	aradford@gmail.com
Subject: Re: State of big-endian for MegaRAID SAS driver
Date: Thu, 15 Aug 2013 21:12:01 -0400	[thread overview]
Message-ID: <yq1haeqcuce.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <FE68512D-F375-456B-948A-492634A02F0F@servergy.com> (Ben Collins's message of "Wed, 14 Aug 2013 22:52:58 -0400")

>>>>> "Ben" == Ben Collins <ben.c@servergy.com> writes:

Ben,

Ben> Considering your patch has had two success stories (I suspect yours
Ben> was on SPARC, so that would even make two different platforms) and
Ben> low likelihood of regression on little endian, I think it's pretty
Ben> safe.

I ordered a MegaRAID card today so I can test on x86 just to be sure.


Ben> The only thing I think that could make it better is to annotate the
Ben> structures in megaraid_sas.h as __le32 where applicable.

I have an older patch that does just that. And another one that gets rid
of the 32-bit DMA limitations on large systems. But I didn't want to
clutter the initial submission.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2013-08-16  1:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 16:57 State of big-endian for MegaRAID SAS driver Ben Collins
2013-08-14 18:11 ` Martin K. Petersen
2013-08-14 19:32   ` Martin K. Petersen
     [not found]   ` <D354E621-BEFA-4010-B5CF-4668939AAEB0@servergy.com>
2013-08-14 19:44     ` Martin K. Petersen
2013-08-15  2:52       ` Ben Collins
2013-08-16  1:12         ` Martin K. Petersen [this message]
2013-08-19 11:16           ` Saxena, Sumit
2013-08-19 17:25             ` Ben Collins
2013-08-26  7:21               ` Saxena, Sumit
2013-08-26  9:05                 ` Christoph Hellwig
2013-08-26 20:15                   ` Maloy, Joe
2013-08-26 20:26                     ` Ben Collins
2013-08-26 20:43                       ` Christoph Hellwig
2013-08-26 20:41                     ` Christoph Hellwig
2013-08-26 22:35                       ` Maloy, Joe
2013-08-26 23:22                         ` Ben Collins
2013-08-26 23:25                 ` Martin K. Petersen
2013-08-26 23:45             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1haeqcuce.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=aradford@gmail.com \
    --cc=ben.c@servergy.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=megaraidlinux@lsi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox