From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: State of big-endian for MegaRAID SAS driver Date: Thu, 15 Aug 2013 21:12:01 -0400 Message-ID: References: <658ABE5F-B2AA-4EC1-BC34-B4FD428C7A8E@servergy.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:32853 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877Ab3HPBMI (ORCPT ); Thu, 15 Aug 2013 21:12:08 -0400 In-Reply-To: (Ben Collins's message of "Wed, 14 Aug 2013 22:52:58 -0400") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Ben Collins Cc: "Martin K. Petersen" , Neela Syam Kolli , linux-scsi , aradford@gmail.com >>>>> "Ben" == Ben Collins writes: Ben, Ben> Considering your patch has had two success stories (I suspect yours Ben> was on SPARC, so that would even make two different platforms) and Ben> low likelihood of regression on little endian, I think it's pretty Ben> safe. I ordered a MegaRAID card today so I can test on x86 just to be sure. Ben> The only thing I think that could make it better is to annotate the Ben> structures in megaraid_sas.h as __le32 where applicable. I have an older patch that does just that. And another one that gets rid of the 32-bit DMA limitations on large systems. But I didn't want to clutter the initial submission. -- Martin K. Petersen Oracle Linux Engineering