[PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[Evan Green]

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
this was the only possible PHY driver Qualcomm's UFS controller
would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the
build.

Signed-off-by: Evan Green <evgreen@chromium.org>
---

 drivers/scsi/ufs/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 2ddbb26d9c265..6db37cf306b05 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -99,7 +99,6 @@ config SCSI_UFS_DWC_TC_PLATFORM
 config SCSI_UFS_QCOM
 	tristate "QCOM specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
-	select PHY_QCOM_UFS
 	help
 	  This selects the QCOM specific additions to UFSHCD platform driver.
 	  UFS host on QCOM needs some vendor specific configuration before
-- 
2.18.1

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[Martin K. Petersen]

Evan,

> CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> this was the only possible PHY driver Qualcomm's UFS controller
> would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> and phy-qcom-ufs is unused.
>
> Remove the select, since for SDM845 it adds useless drivers to the
> build.

Applied to 5.1/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[Doug Anderson]

Hi,

On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> Evan,
>
> > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > this was the only possible PHY driver Qualcomm's UFS controller
> > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > and phy-qcom-ufs is unused.
> >
> > Remove the select, since for SDM845 it adds useless drivers to the
> > build.
>
> Applied to 5.1/scsi-queue.

Should this be accompanied by a change to arch/arm64/configs/defconfig
that sets 'CONFIG_PHY_QCOM_UFS=m'?  I don't personally have any
non-SDM845 devices to test on, but I'm sorta assuming they will all
break without the defconfig update?

Added a few more people (and linux-arm-msm list) to this thread in
case this matters to anyone.

-Doug

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[Evan Green]

On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
> <martin.petersen@oracle.com> wrote:
> >
> >
> > Evan,
> >
> > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > > this was the only possible PHY driver Qualcomm's UFS controller
> > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > > and phy-qcom-ufs is unused.
> > >
> > > Remove the select, since for SDM845 it adds useless drivers to the
> > > build.
> >
> > Applied to 5.1/scsi-queue.
>
> Should this be accompanied by a change to arch/arm64/configs/defconfig
> that sets 'CONFIG_PHY_QCOM_UFS=m'?  I don't personally have any
> non-SDM845 devices to test on, but I'm sorta assuming they will all
> break without the defconfig update?

Right, thanks for pointing that out. I'll send out another patch to
tweak the defconfig.
-Evan

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

[Evan Green]

On Mon, Jan 14, 2019 at 10:41 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
> > <martin.petersen@oracle.com> wrote:
> > >
> > >
> > > Evan,
> > >
> > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > > > this was the only possible PHY driver Qualcomm's UFS controller
> > > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > > > and phy-qcom-ufs is unused.
> > > >
> > > > Remove the select, since for SDM845 it adds useless drivers to the
> > > > build.
> > >
> > > Applied to 5.1/scsi-queue.
> >
> > Should this be accompanied by a change to arch/arm64/configs/defconfig
> > that sets 'CONFIG_PHY_QCOM_UFS=m'?  I don't personally have any
> > non-SDM845 devices to test on, but I'm sorta assuming they will all
> > break without the defconfig update?
>
> Right, thanks for pointing that out. I'll send out another patch to
> tweak the defconfig.

Sent out at:
https://lore.kernel.org/lkml/20190114190112.167922-1-evgreen@chromium.org/T/#u