From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v1] mptfusion: Use snprintf() instead of open coded divisions
Date: Wed, 17 Jan 2018 01:14:21 -0500 [thread overview]
Message-ID: <yq1inc1t3k2.fsf@oracle.com> (raw)
In-Reply-To: <20180115170558.86823-1-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Mon, 15 Jan 2018 19:05:58 +0200")
Andy,
> Numbers up to 100 snprintf() prints without using a division.
> Besides that the code looks more readable.
Applied to 4.16/scsi-queue (despite not really being a fan of cleaning
up dead code). Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-01-17 6:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 17:05 [PATCH v1] mptfusion: Use snprintf() instead of open coded divisions Andy Shevchenko
2018-01-17 6:14 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1inc1t3k2.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chaitra.basappa@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).