* [PATCH v2] scsi: logging: update description of logging_level bits
@ 2017-10-11 17:09 Randy Dunlap
2017-10-11 17:11 ` Kyle Fortin
2017-10-11 18:22 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2017-10-11 17:09 UTC (permalink / raw)
To: linux-scsi, Martin K. Petersen, James E.J. Bottomley
Cc: Kyle Fortin, Steffen Maier
From: Randy Dunlap <rdunlap@infradead.org>
Update the description of 'scsi_logging_level' from 8 4-bit nibbles
to the (pre-git) reality of 10 3-bit bitfields.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Kyle Fortin <kyle.fortin@oracle.com>
Reviewed-by: Steffen Maier <maier@linux.vnet.ibm.com>
---
drivers/scsi/scsi_logging.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
v2: change 3-bit 'nibbles' to 3-bit bitfields.
add Reviewed-bys.
--- lnx-414-rc3.orig/drivers/scsi/scsi_logging.h
+++ lnx-414-rc3/drivers/scsi/scsi_logging.h
@@ -3,10 +3,10 @@
/*
- * This defines the scsi logging feature. It is a means by which the user
- * can select how much information they get about various goings on, and it
- * can be really useful for fault tracing. The logging word is divided into
- * 8 nibbles, each of which describes a loglevel. The division of things is
+ * This defines the scsi logging feature. It is a means by which the user can
+ * select how much information they get about various goings on, and it can be
+ * really useful for fault tracing. The logging word is divided into 10 3-bit
+ * bitfields, each of which describes a loglevel. The division of things is
* somewhat arbitrary, and the division of the word could be changed if it
* were really needed for any reason. The numbers below are the only place
* where these are specified. For a first go-around, 3 bits is more than
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: logging: update description of logging_level bits
2017-10-11 17:09 [PATCH v2] scsi: logging: update description of logging_level bits Randy Dunlap
@ 2017-10-11 17:11 ` Kyle Fortin
2017-10-11 18:22 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Kyle Fortin @ 2017-10-11 17:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-scsi, Martin K. Petersen, James E.J. Bottomley,
Steffen Maier
Looks good.
Reviewed-by: Kyle Fortin <kyle.fortin@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] scsi: logging: update description of logging_level bits
2017-10-11 17:09 [PATCH v2] scsi: logging: update description of logging_level bits Randy Dunlap
2017-10-11 17:11 ` Kyle Fortin
@ 2017-10-11 18:22 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-10-11 18:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-scsi, Martin K. Petersen, James E.J. Bottomley, Kyle Fortin,
Steffen Maier
Randy,
> Update the description of 'scsi_logging_level' from 8 4-bit nibbles
> to the (pre-git) reality of 10 3-bit bitfields.
Applied to 4.15/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-11 17:09 [PATCH v2] scsi: logging: update description of logging_level bits Randy Dunlap
2017-10-11 17:11 ` Kyle Fortin
2017-10-11 18:22 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).