From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>,
Mike Christie <michael.christie@oracle.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v2 1/2] scsi: core: Retry passthrough commands if SCMD_RETRY_PASSTHROUGH is set
Date: Wed, 28 Aug 2024 22:46:20 -0400 [thread overview]
Message-ID: <yq1jzg0cbhy.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240809193115.1222737-2-bvanassche@acm.org> (Bart Van Assche's message of "Fri, 9 Aug 2024 12:31:13 -0700")
Hi Bart!
Sorry this took so long. I have made several attempts at automatically
retrying commands originating from within SCSI since the lack of retries
is a general problem.
However, in the end I prefer the approach of describing the specific
conditions we want handled using scsi_failure at each call site. Works
well.
> The SCSI core does not retry passthrough commands even if the SCSI
> device reports a retryable unit attention condition. Support retrying
> in this case by introducing the SCMD_RETRY_PASSTHROUGH flag.
FWIW, I find the use of "passthrough" to describe commands issued by the
SCSI layer quite confusing.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-08-29 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 19:31 [PATCH v2 0/2] Fix system resume for SCSI devices Bart Van Assche
2024-08-09 19:31 ` [PATCH v2 1/2] scsi: core: Retry passthrough commands if SCMD_RETRY_PASSTHROUGH is set Bart Van Assche
2024-08-19 23:25 ` Damien Le Moal
2024-08-19 23:29 ` Bart Van Assche
2024-08-29 2:46 ` Martin K. Petersen [this message]
2024-08-09 19:31 ` [PATCH v2 2/2] sd: Retry START STOP UNIT commands Bart Van Assche
2024-08-19 23:26 ` Damien Le Moal
2024-08-09 22:13 ` [PATCH v2 0/2] Fix system resume for SCSI devices Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1jzg0cbhy.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox