From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCHv3 2/5] scsi: Export blacklist flags to sysfs Date: Wed, 16 Aug 2017 20:10:50 -0400 Message-ID: References: <1502461401-94630-1-git-send-email-hare@suse.de> <1502461401-94630-3-git-send-email-hare@suse.de> <1502837223.2259.15.camel@wdc.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:41350 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdHQAME (ORCPT ); Wed, 16 Aug 2017 20:12:04 -0400 In-Reply-To: (Hannes Reinecke's message of "Wed, 16 Aug 2017 07:56:19 +0200") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke Cc: Bart Van Assche , "martin.petersen@oracle.com" , "hch@lst.de" , "james.bottomley@hansenpartnership.com" , "linux-scsi@vger.kernel.org" , "hare@suse.com" , "stern@rowland.harvard.edu" Hannes, > I still would like to keep the above, as the admin can feed blacklist > flags via the kernel commandline, and we don't do any validity checks on > that. So we might end up with invalid flags after all. I suggest you handle this by printing something along the lines of "INVALID_BIT_SET(42)" for each bad flag. Also: Brownie points for adding a new sysfs interface to augment the existing /proc goo for adding entries. Preferably one that takes BLIST names instead of huge hex numbers. -- Martin K. Petersen Oracle Linux Engineering