From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param Date: Mon, 27 Feb 2017 22:24:25 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:32688 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbdB1D0W (ORCPT ); Mon, 27 Feb 2017 22:26:22 -0500 In-Reply-To: (MichalX Potomski's message of "Thu, 23 Feb 2017 09:05:30 +0000") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Potomski, MichalX" Cc: "'vinholikatti@gmail.com'" , "'subhashj@codeaurora.org'" , "'jejb@linux.vnet.ibm.com'" , "'martin.petersen@oracle.com'" , "'linux-scsi@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" , "Janca, Grzegorz" , "Mielczarek, SzymonX" >>>>> "Michal" == Potomski, MichalX writes: Michal> Since in UFS 2.1 specification some of the descriptor lengths Michal> differs from 2.0 specification and some devices, which are Michal> reporting spec version 2.0 have different descriptor lengths we Michal> can not rely on hardcoded values taken from 2.0 Michal> specification. This patch introduces reading these lengths per Michal> each device from descriptor headers at probe time to ensure Michal> their correctness. Subhash: I assume v2 still carries your Reviewed-by:? -- Martin K. Petersen Oracle Linux Engineering