From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: James Bottomley <James.Bottomley@suse.de>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi <linux-scsi@vger.kernel.org>,
dm-devel@redhat.com
Subject: Re: [RFC 1/2] block: implement an unprep function corresponding directly to prep
Date: Wed, 30 Jun 2010 13:54:46 -0400 [thread overview]
Message-ID: <yq1k4pg2yop.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4C2B8412.6040807@kernel.dk> (Jens Axboe's message of "Wed, 30 Jun 2010 19:51:14 +0200")
>>>>> "Jens" == Jens Axboe <axboe@kernel.dk> writes:
Jens> On 30/06/10 19.01, James Bottomley wrote:
>> So this is more directly what I'm thinking. It gives us an exactly
>> correct place to hang the discard allocation in SCSI. The next patch
>> shows a potential implementation in sd.
>>
>> I think it should avoid all the leaks people have been seeing trying
>> to move the discard allocation/free into scsi. I also think it
>> should facilitate sending discard through SCSI as a REQ_TYPE_FS.
Jens> This is so much better than the other hacks, thanks for doing
Jens> this.
Agreed!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-06-30 17:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 17:01 [RFC 1/2] block: implement an unprep function corresponding directly to prep James Bottomley
2010-06-30 17:10 ` [RFC 2/2] sd: free discard page in unprep function James Bottomley
2010-06-30 17:23 ` [RFC 1/2] block: implement an unprep function corresponding directly to prep Mike Snitzer
2010-06-30 17:51 ` Jens Axboe
2010-06-30 17:54 ` Martin K. Petersen [this message]
2010-07-01 1:47 ` FUJITA Tomonori
2010-07-01 3:47 ` Mike Snitzer
2010-07-01 4:44 ` [dm-devel] " FUJITA Tomonori
2010-07-02 11:03 ` Christoph Hellwig
2010-07-05 7:00 ` FUJITA Tomonori
2010-07-05 19:24 ` Christoph Hellwig
2010-07-05 21:50 ` Mark Lord
2010-07-05 21:54 ` Mark Lord
2010-07-05 22:00 ` Jeff Garzik
2010-08-03 3:01 ` Mark Lord
2010-07-06 7:04 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k4pg2yop.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox