From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] SCSI: Make error printing more user friendly Date: Mon, 19 Feb 2007 10:43:09 -0500 Message-ID: References: <1171638659.3443.8.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:50839 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932368AbXBSPnr (ORCPT ); Mon, 19 Feb 2007 10:43:47 -0500 In-Reply-To: <1171638659.3443.8.camel@mulgrave.il.steeleye.com> (James Bottomley's message of "Fri, 16 Feb 2007 09:10:59 -0600") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: "Martin K. Petersen" , linux-scsi@vger.kernel.org >>>>> "James" == James Bottomley writes: James> I think we should be going through dev_printk as the primary, James> particularly as doing this would make the output of sdev_printk James> different from scmd_printk. How about Fine with me except we're now back to having inconsistent prefixes for the result printing and the matching sense data. I'll try to sanitize the sense printing too and post a new patch. James> The other nasty is that we can't actually deref rq_disk unless James> is included. You'll find megaraid_sas.c fails James> to compile becuase of this. It can probably be fixed by James> including blkdev.h from scsi_device.h You must have had a reject on scsi_device.h. My patch did include to fix that very issue. -- Martin K. Petersen Oracle Linux Engineering