From: "Martin K. Petersen (Oracle)" <mkp@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, John Garry <john.garry@linux.dev>,
Hannes Reinecke <hare@kernel.org>
Subject: Re: [PATCH] scsi: core: Micro-optimize the hot path
Date: Sat, 03 Oct 2026 09:49:52 -0400 [thread overview]
Message-ID: <yq1ld8elwqy.fsf@mail.kernel.org> (raw)
In-Reply-To: <1ac0d4d0c06e55943e188d0dee9b6f2475715f21.1790359761.git.bvanassche@acm.org>
Bart,
> Every code path that inserts scmd->eh_entry into a list uses
> list_add_tail() (see also scsi_abort_command() and scsi_eh_scmd_add()).
> list_add_tail() overwrites the next and prev pointers. Hence, the only
> code that depends on the initialization of scmd->eh_entry is the
> BUG_ON(!list_empty(&scmd->eh_entry)) statement in scsi_abort_command().
Applied to 7.4/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-10-03 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 18:09 [PATCH] scsi: core: Micro-optimize the hot path Bart Van Assche
2026-09-28 8:58 ` John Garry
2026-10-03 9:16 ` Hannes Reinecke
2026-10-03 13:49 ` Martin K. Petersen (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ld8elwqy.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=bvanassche@acm.org \
--cc=hare@kernel.org \
--cc=john.garry@linux.dev \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox