* [PATCH] scsi: isci: init Return result of sas_register_ha()
@ 2023-08-13 20:23 Artem Chernyshev
2023-08-16 7:40 ` Artur Paszkiewicz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Artem Chernyshev @ 2023-08-13 20:23 UTC (permalink / raw)
To: Artur Paszkiewicz
Cc: Artem Chernyshev, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, linux-kernel, lvc-project
To properly manage possible failure of sas_register_ha() in
isci_register_sas_ha() return it's result instead of zero
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
drivers/scsi/isci/init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index ac1e04b86d8f..4f4800edf4f0 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -264,9 +264,7 @@ static int isci_register_sas_ha(struct isci_host *isci_host)
sas_ha->strict_wide_ports = 1;
- sas_register_ha(sas_ha);
-
- return 0;
+ return sas_register_ha(sas_ha);
}
static void isci_unregister(struct isci_host *isci_host)
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
2023-08-13 20:23 [PATCH] scsi: isci: init Return result of sas_register_ha() Artem Chernyshev
@ 2023-08-16 7:40 ` Artur Paszkiewicz
2023-08-21 20:39 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Artur Paszkiewicz @ 2023-08-16 7:40 UTC (permalink / raw)
To: Artem Chernyshev
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
linux-kernel, lvc-project
On 13.08.2023 22:23, Artem Chernyshev wrote:
> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
2023-08-13 20:23 [PATCH] scsi: isci: init Return result of sas_register_ha() Artem Chernyshev
2023-08-16 7:40 ` Artur Paszkiewicz
@ 2023-08-21 20:39 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-08-21 20:39 UTC (permalink / raw)
To: Artem Chernyshev
Cc: Artur Paszkiewicz, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, linux-kernel, lvc-project
Artem,
> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
2023-08-13 20:23 [PATCH] scsi: isci: init Return result of sas_register_ha() Artem Chernyshev
2023-08-16 7:40 ` Artur Paszkiewicz
2023-08-21 20:39 ` Martin K. Petersen
@ 2023-08-25 1:12 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2023-08-25 1:12 UTC (permalink / raw)
To: Artur Paszkiewicz, Artem Chernyshev
Cc: Martin K . Petersen, James E . J . Bottomley, linux-scsi,
linux-kernel, lvc-project
On Sun, 13 Aug 2023 23:23:36 +0300, Artem Chernyshev wrote:
> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
>
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: isci: init Return result of sas_register_ha()
https://git.kernel.org/mkp/scsi/c/9a23ed57abbb
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-25 1:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-13 20:23 [PATCH] scsi: isci: init Return result of sas_register_ha() Artem Chernyshev
2023-08-16 7:40 ` Artur Paszkiewicz
2023-08-21 20:39 ` Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox