From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Wen Xiong <wenxiong@us.ibm.com>,
brking@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH V2 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1"
Date: Tue, 14 Sep 2021 14:13:07 -0400 [thread overview]
Message-ID: <yq1lf3zxd38.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <743e68034d12f839a6bfbc6eab27562afcb5cf70.camel@linux.ibm.com> (James Bottomley's message of "Tue, 14 Sep 2021 08:50:10 -0700")
James,
> I still think setting expecting_cc_ua is the best thing to do because
> it's designed for exactly the problem you're seeing, but open coding
> it in the loop would be fine as well.
The problem with that approach is that (as far as I can tell) we didn't
issue the reset in question.
We could explicitly set the flag in ses_recv_diag(). However, even
though scsi_check_sense() returns RETRY, scsi_decide_disposition()
bypasses it because a check condition is considered a "no retry" command
by scsi_noretry_cmd(). So despite expecting_cc_ua being set, the retry
is not performed.
Fun can of worms...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-14 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 19:04 [PATCH V2 1/1] scsi/ses: Saw "Failed to get diagnostic page 0x1" wenxiong
2021-09-11 0:23 ` kernel test robot
2021-09-11 0:44 ` James Bottomley
[not found] ` <f754c31d348465f96ad4cd7541a86168@imap.linux.ibm.com>
2021-09-13 21:13 ` Martin K. Petersen
[not found] ` <OF31B21169.103CCF65-ON0025874F.00776468-0025874F.00778F79@ibm.com>
2021-09-14 15:27 ` Martin K. Petersen
2021-09-14 15:50 ` James Bottomley
2021-09-14 18:13 ` Martin K. Petersen [this message]
2021-09-14 15:52 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lf3zxd38.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@linux.vnet.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).