From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 507EAC43603 for ; Tue, 17 Dec 2019 03:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 226052072B for ; Tue, 17 Dec 2019 03:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="qGxS/5N5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbfLQDFS (ORCPT ); Mon, 16 Dec 2019 22:05:18 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48136 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbfLQDFS (ORCPT ); Mon, 16 Dec 2019 22:05:18 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBH34QWY094466; Tue, 17 Dec 2019 03:05:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=kWql0myD+1xkrJZYUwTHqbtRusbfwuazmmLBPvIG05E=; b=qGxS/5N5+L37v91BKlLkpITfSIAbJKF4wrYyxsfbvxmVyngXeB5I2BHsoXTnR7bkxBHW emgZ32jX29OZrNmI4LSCYSR3KltGKR+7Y/YAzUbXekEPZnAGO/E5BUlGXOKLAyUv0jyN dYWAdTnEhuBwpO67i04pXtI/5VM0NezOG4LZDWmVqHQfTr2Zfhr/QTXey64lLYtOT3T1 4FJGq+X0bm6OaNXCbm6LKSNf0h7bSkbM+8Y4XTy+KARxwbqkU4vgnXRzoRZA/ksvydgN fGn7QdTGSETrzoh57FPVoYZnaDcrNlHob8SrgWtBMQvqHIz3JFkhmty139zoBIWBZUT+ SQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2wvqpq3q1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Dec 2019 03:04:59 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBH34Lq2105561; Tue, 17 Dec 2019 03:04:59 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2wxm5mdy8s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Dec 2019 03:04:59 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xBH34uf8020323; Tue, 17 Dec 2019 03:04:56 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Dec 2019 19:04:55 -0800 To: Dan Carpenter Cc: Alim Akhtar , Bart Van Assche , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Bean Huo , Stanley Chu , Can Guo , Venkat Gopalakrishnan , Tomas Winkler , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] scsi: ufs: Unlock on a couple error paths From: "Martin K. Petersen" Organization: Oracle Corporation References: <20191213104828.7i64cpoof26rc4fw@kili.mountain> Date: Mon, 16 Dec 2019 22:04:52 -0500 In-Reply-To: <20191213104828.7i64cpoof26rc4fw@kili.mountain> (Dan Carpenter's message of "Fri, 13 Dec 2019 13:48:28 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9473 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=965 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912170026 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9473 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912170026 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Dan, > We introduced a few new error paths, but we can't return directly, we > first have to unlock "hba->clk_scaling_lock" first. Applied #1 + #2 to 5.6/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering