From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v5 1/2] scsi: ufs: Do not disable vccq in UFSHC driver Date: Tue, 26 Feb 2019 15:00:17 -0500 Message-ID: References: <494cd639-89a7-8868-b63a-ea7cdcba9777@free.fr> <026c10b1-48e8-ab9f-fda8-6e3557b841a7@free.fr> <8fc2eed2-f94b-8d43-6ca4-86e18f600997@free.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <8fc2eed2-f94b-8d43-6ca4-86e18f600997@free.fr> (Marc Gonzalez's message of "Tue, 26 Feb 2019 18:02:18 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Marc Gonzalez Cc: "Martin K. Petersen" , SCSI , LKML , Jeffrey Hugo , Bjorn Andersson , Evan Green , Douglas Anderson , Alim Akhtar , Avri Altman , Pedro Sousa , Joao Pinto , Mark Brown , Liam Girdwood , Rob Herring , Bart Van Assche , Stanislav Nijnikov , Alex Lemberg , Ohad Sharabi , Hannes Reinecke , Kyuho Choi List-Id: linux-scsi@vger.kernel.org Marc, > The resolution is simple: we keep the HEAD version, and simply remove > ufshcd_set_vccq_rail_unused() and its error-handling. > > > Is that the information you were after? Yes. > Do you prefer the patch subject to be: > Revert "scsi: ufs: disable vccq if it's not needed by UFS device" > instead of: > scsi: ufs: Do not disable vccq in UFSHC driver > > And I should leave in the automatically added > This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. > while adding some information from the manual resolution? Exactly. Thanks! -- Martin K. Petersen Oracle Linux Engineering