From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: megaraid: Convert timers to use timer_setup() Date: Tue, 31 Oct 2017 11:45:37 -0400 Message-ID: References: <20171025100720.GA145069@beast> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171025100720.GA145069@beast> (Kees Cook's message of "Wed, 25 Oct 2017 03:07:20 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: "Martin K. Petersen" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Also > consolidates the timer setup functions arguments, which are all > identical, and corrects on-stack timer usage. Same with this one. Broadcom folks, please review! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering