From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Finn Thain <fthain@telegraphics.com.au>,
Ondrej Zary <linux@rainbow-software.org>,
Michael Schmitz <schmitzmic@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock
Date: Mon, 24 Apr 2017 18:29:50 -0400 [thread overview]
Message-ID: <yq1lgqph21t.fsf@oracle.com> (raw)
In-Reply-To: <1ecb1ec37388c616335dba37b42b4a7676df6c1e.1491115954.git.fthain@telegraphics.com.au> (Finn Thain's message of "Sun, 02 Apr 2017 17:08:05 +1000")
Finn,
> Commit da244654c66e ("[SCSI] mac_esp: fix for quadras with two esp chips")
> added mac_scsi_esp_intr() to handle the IRQ lines from a pair of on-board
> ESP chips (a normal shared IRQ did not work).
>
> Proper mutual exclusion was missing from that patch. This patch fixes
> race conditions between comparison and assignment of esp_chips[]
> pointers.
Ondrej/Michael: Mind reviewing this change?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-24 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 7:08 [PATCH] scsi/mac_esp: Replace bogus memory barrier with spinlock Finn Thain
2017-04-24 22:29 ` Martin K. Petersen [this message]
2017-04-24 23:25 ` Michael Schmitz
2017-04-24 23:29 ` Martin K. Petersen
2017-04-25 2:14 ` Michael Schmitz
2017-04-25 16:53 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1lgqph21t.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=fthain@telegraphics.com.au \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox