From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [patch] qla2xxx: fix a timeout loop Date: Wed, 16 Dec 2015 17:50:17 -0500 Message-ID: References: <20151216110746.GB21018@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:50728 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbbLPWud (ORCPT ); Wed, 16 Dec 2015 17:50:33 -0500 In-Reply-To: <20151216110746.GB21018@mwanda> (Dan Carpenter's message of "Wed, 16 Dec 2015 14:07:46 +0300") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter Cc: qla2xxx-upstream@qlogic.com, Atul Deshmukh , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, Johannes Thumshirn >>>>> "Dan" == Dan Carpenter writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead. Applied to 4.4/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering