From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [patch 17/18] scsi: select CRC_T10DIF only when necessary Date: Thu, 21 Aug 2008 10:49:41 -0400 Message-ID: References: <200808202355.m7KNtaxo006233@imap1.linux-foundation.org> <1219328396.3265.4.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:23063 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbYHUOut (ORCPT ); Thu, 21 Aug 2008 10:50:49 -0400 In-Reply-To: <1219328396.3265.4.camel@localhost.localdomain> (James Bottomley's message of "Thu\, 21 Aug 2008 09\:19\:56 -0500") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: "Martin K. Petersen" , akpm@linux-foundation.org, linux-scsi@vger.kernel.org, stefanr@s5r6.in-berlin.de >>>>> "James" == James Bottomley writes: James> Actually, I don't think this is right at all. James> This is a purely cosmetic fix and the tip of the iceberg. If James> not compiling in the integrity code matters on grounds of James> kernel bloat, and I think it does, then the correct fix is to James> make sure none of it compiles into SD if BLK_DEV_INTEGRITY James> isn't set. The only code that currently uses the T10 CRC is in sd_dif.c. And that file isn't compiled in if BLK_DEV_INTEGRITY isn't set. -- Martin K. Petersen Oracle Linux Engineering