From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kurt Garloff <kurt@garloff.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: Patch [0/3] Support eager_unmap for non ldpme sd devs
Date: Tue, 29 Jul 2025 01:09:29 -0400 [thread overview]
Message-ID: <yq1ms8nlhtk.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <936a460e-eacd-40a8-834a-76021bf3ce8c@garloff.de> (Kurt Garloff's message of "Sun, 27 Jul 2025 20:06:38 +0200")
Hi Kurt!
> The SCSI disk driver (sd_mod) would just claim that discard is not
> supported. It's not true. The NVMes support it as do the enclosures.
For some definition of support at least. If they can't figure out how to
set a single bit flag to enable the feature, then maybe their "support"
is not entirely trustworthy. But great that it works...
What are your devices actually reporting in:
# sg_readcap -l /dev/sdN
# sg_vpd -p bl /dev/sdN
# sg_vpd -p lbpv /dev/sdN
?
> I have a few, though all have variants of RTL9210 chips.
>
> But sd was too conservative to let me do it.
Why not just have a udev rule which does:
echo unmap > /sys/class/scsi_disk/H:C:T:L/provisioning_mode
?
Substitute "writesame_10" or "writesame_16" depending on what is
actually implemented.
--
Martin K. Petersen
next prev parent reply other threads:[~2025-07-29 5:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-27 18:06 Patch [0/3] Support eager_unmap for non ldpme sd devs Kurt Garloff
2025-07-28 15:35 ` Bart Van Assche
2025-07-29 5:09 ` Martin K. Petersen [this message]
2025-07-29 7:32 ` Kurt Garloff
2025-07-29 9:15 ` Kurt Garloff
2025-07-29 9:37 ` Kurt Garloff
2025-07-31 4:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ms8nlhtk.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=kurt@garloff.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox