From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: core: simplify control flow in scmd_eh_abort_handler
Date: Wed, 27 Oct 2021 23:31:01 -0400 [thread overview]
Message-ID: <yq1mtmtygg2.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20211025143952.17128-3-emilne@redhat.com> (Ewan D. Milne's message of "Mon, 25 Oct 2021 10:39:52 -0400")
Ewan,
> Simplify the nested conditionals in the function by using
> a label for the error path, and remove duplicate code.
Oh, I see you shuffled things for the follow-on patch. That's
better. I'd still like the stable fix to be smaller, though.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-10-28 3:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:39 [PATCH 0/2] Fix SCSI async abort handling when eh_deadline is active Ewan D. Milne
2021-10-25 14:39 ` [PATCH 1/2] scsi: core: avoid leaving shost->last_reset with stale value if EH does not run Ewan D. Milne
2021-10-28 3:29 ` Martin K. Petersen
2021-10-28 20:44 ` Ewan D. Milne
2021-10-25 14:39 ` [PATCH 2/2] scsi: core: simplify control flow in scmd_eh_abort_handler Ewan D. Milne
2021-10-28 3:31 ` Martin K. Petersen [this message]
2021-10-28 20:45 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mtmtygg2.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox