From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F179CC4167B for ; Wed, 9 Dec 2020 16:59:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F33623C44 for ; Wed, 9 Dec 2020 16:59:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732237AbgLIQ6q (ORCPT ); Wed, 9 Dec 2020 11:58:46 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:33198 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731748AbgLIQ6j (ORCPT ); Wed, 9 Dec 2020 11:58:39 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9Gtdxh045778; Wed, 9 Dec 2020 16:57:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=c1I0nlR7jgfWedPW3jV53XSfpcSGwN/wSxs+VvsS4kQ=; b=imfOs17U3SdGmUs6xmBcfDcUlh2tFcwhqU84RQUwtdC2jZm+ppdrZdpn1BtJEe3DDK0I 80n5jmE9UaK7+cNDqcMCILnco5luLMASTd2artuMwbVhKqG+CVi9Z0bHqAHmxFSoOdcs g9tZSD5qStdmRFTZaHw6ngPkNdCkhK7q42m5Fp7uAvfVcQxzqjcpNQUewiLMYsZTYGUl XIxTgGj2Twm9U28IxzABq28Yhg4qxvu2VOeNaV+3IpkaGa2FBH16/H2KVOJTyKm3Xw9V pFBfYrUNY83kPoMZKgnCf0+i03rH6fvrMLymW0btx/yCzqAM/RrKqZWRWTKYFhXEpwhd 1g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 35825m9874-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Dec 2020 16:57:55 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B9GtmoR191165; Wed, 9 Dec 2020 16:57:54 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 358m50vchv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Dec 2020 16:57:54 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0B9GvrDb006147; Wed, 9 Dec 2020 16:57:53 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Dec 2020 08:57:52 -0800 To: Dan Carpenter Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: mpt3sas: Signedness bug in _base_get_diag_triggers() From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: Date: Wed, 09 Dec 2020 11:57:50 -0500 In-Reply-To: (Dan Carpenter's message of "Wed, 9 Dec 2020 17:03:11 +0300") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=1 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090119 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9829 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012090119 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Dan, > The "trigger_flags" variable needs to be signed for the error checking > to work. Applied to 5.11/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering