From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A06C432C3 for ; Tue, 19 Nov 2019 04:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A05B922318 for ; Tue, 19 Nov 2019 04:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ck/uq3no" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727617AbfKSEcv (ORCPT ); Mon, 18 Nov 2019 23:32:51 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:49530 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727217AbfKSEcu (ORCPT ); Mon, 18 Nov 2019 23:32:50 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJ4ODF7090371; Tue, 19 Nov 2019 04:32:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=mI7i+8fMH9XzWsU8aUL2eoc7knC5XOFnHhg7fkCXrOg=; b=ck/uq3no02yLim/AgdHB8tMmHHTRae+M4hPhzD/3BBaKo9fGqsM+33oKvrr8xKUefn1h ZDwx3BYn5J0DuoSi3DUYmD8/+7WQQRz2OuofoygLID5HkHMTOdu0mnIUhBoAqWCvZSWa fD3w6QI0VL0ySwU8oUOqfswdwZrDj0Xzs3/lrcxw8sbsRgsOt8mzM8TlbGzCn9CxUkbA dz4QT45y0zJeHfHgrqro2K00q0rcwzLQZ8xBbNRWDZ9WXU1GOibnoSmf4BwJMN9SXKXr 3LwXElyMWQdfQ9xv0EX9uaeE/POS0GnPVxxwMOElxj1nV69DVusJtpB6uXS+OXExuWqH hg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2wa8htmdnt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 04:32:43 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJ4SuHJ190376; Tue, 19 Nov 2019 04:30:43 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2wc09wq26r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 04:30:43 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xAJ4UdKC022160; Tue, 19 Nov 2019 04:30:42 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 18 Nov 2019 20:30:39 -0800 To: Pan Bian Cc: QLogic-Storage-Upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] SCSI: qla4xxx: fix double free bug From: "Martin K. Petersen" Organization: Oracle Corporation References: <1572945927-27796-1-git-send-email-bianpan2016@163.com> Date: Mon, 18 Nov 2019 23:30:37 -0500 In-Reply-To: <1572945927-27796-1-git-send-email-bianpan2016@163.com> (Pan Bian's message of "Tue, 5 Nov 2019 17:25:27 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=823 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190039 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=908 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190039 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Pan, > The variable init_fw_cb is released twice, resulting in a double free > bug. The call to the function dma_free_coherent() before goto is > removed to get rid of potential double free. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering