* [PATCH -next] scsi: smartpqi: remove set but not used variable 'ctrl_info'
@ 2019-08-31 13:03 YueHaibing
2019-10-01 2:38 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-08-31 13:03 UTC (permalink / raw)
To: Don Brace, James E.J. Bottomley, Murthy Bhat, Martin K. Petersen
Cc: YueHaibing, esc.storagedev, linux-scsi, linux-kernel,
kernel-janitors, Hulk Robot
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_driver_version_show':
drivers/scsi/smartpqi/smartpqi_init.c:6164:24: warning:
variable 'ctrl_info' set but not used [-Wunused-but-set-variable]
commit 6d90615f1346 ("scsi: smartpqi: add sysfs entries") add it but never
use, so remove it also variable 'shost'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/smartpqi/smartpqi_init.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
index ea5409bebf57..b9e7dabee1e5 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -6160,12 +6160,6 @@ static ssize_t pqi_firmware_version_show(struct device *dev,
static ssize_t pqi_driver_version_show(struct device *dev,
struct device_attribute *attr, char *buffer)
{
- struct Scsi_Host *shost;
- struct pqi_ctrl_info *ctrl_info;
-
- shost = class_to_shost(dev);
- ctrl_info = shost_to_hba(shost);
-
return snprintf(buffer, PAGE_SIZE,
"%s\n", DRIVER_VERSION BUILD_TIMESTAMP);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: smartpqi: remove set but not used variable 'ctrl_info'
2019-08-31 13:03 [PATCH -next] scsi: smartpqi: remove set but not used variable 'ctrl_info' YueHaibing
@ 2019-10-01 2:38 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-01 2:38 UTC (permalink / raw)
To: YueHaibing
Cc: Don Brace, James E.J. Bottomley, Murthy Bhat, Martin K. Petersen,
esc.storagedev, linux-scsi, linux-kernel, kernel-janitors,
Hulk Robot
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_driver_version_show':
> drivers/scsi/smartpqi/smartpqi_init.c:6164:24: warning:
> variable 'ctrl_info' set but not used [-Wunused-but-set-variable]
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-01 2:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-31 13:03 [PATCH -next] scsi: smartpqi: remove set but not used variable 'ctrl_info' YueHaibing
2019-10-01 2:38 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).