* [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp'
@ 2019-05-31 15:27 YueHaibing
2019-06-04 17:34 ` James Smart
2019-06-05 2:30 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-31 15:27 UTC (permalink / raw)
To: james.smart, dick.kennedy, jejb, martin.petersen, jsmart2021
Cc: linux-kernel, linux-scsi, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warnings:
drivers/scsi/lpfc/lpfc_init.c: In function lpfc_setup_cq_lookup:
drivers/scsi/lpfc/lpfc_init.c:9359:30: warning: variable qp set but not used [-Wunused-but-set-variable]
It's not used since commit e70596a60f88 ("scsi: lpfc: Fix
poor use of hardware queues if fewer irq vectors")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 24965a06f55d..cd8e47544d07 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -9356,10 +9356,8 @@ static void
lpfc_setup_cq_lookup(struct lpfc_hba *phba)
{
struct lpfc_queue *eq, *childq;
- struct lpfc_sli4_hdw_queue *qp;
int qidx;
- qp = phba->sli4_hba.hdwq;
memset(phba->sli4_hba.cq_lookup, 0,
(sizeof(struct lpfc_queue *) * (phba->sli4_hba.cq_max + 1)));
/* Loop thru all IRQ vectors */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp'
2019-05-31 15:27 [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp' YueHaibing
@ 2019-06-04 17:34 ` James Smart
2019-06-05 2:30 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2019-06-04 17:34 UTC (permalink / raw)
To: YueHaibing, dick.kennedy, jejb, martin.petersen, jsmart2021
Cc: linux-kernel, linux-scsi
On 5/31/2019 8:27 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warnings:
>
> drivers/scsi/lpfc/lpfc_init.c: In function lpfc_setup_cq_lookup:
> drivers/scsi/lpfc/lpfc_init.c:9359:30: warning: variable qp set but not used [-Wunused-but-set-variable]
>
> It's not used since commit e70596a60f88 ("scsi: lpfc: Fix
> poor use of hardware queues if fewer irq vectors")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
Looks good - thank You
Reviewed-by: James Smart <james.smart@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp'
2019-05-31 15:27 [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp' YueHaibing
2019-06-04 17:34 ` James Smart
@ 2019-06-05 2:30 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2019-06-05 2:30 UTC (permalink / raw)
To: YueHaibing
Cc: james.smart, dick.kennedy, jejb, martin.petersen, jsmart2021,
linux-kernel, linux-scsi
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warnings:
>
> drivers/scsi/lpfc/lpfc_init.c: In function lpfc_setup_cq_lookup:
> drivers/scsi/lpfc/lpfc_init.c:9359:30: warning: variable qp set but not used [-Wunused-but-set-variable]
Applied to 5.3/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-05 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-31 15:27 [PATCH -next] scsi: lpfc: Remove set but not used variables 'qp' YueHaibing
2019-06-04 17:34 ` James Smart
2019-06-05 2:30 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).