From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: matthew@wil.cx, hare@suse.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback
Date: Tue, 16 Oct 2018 21:34:00 -0400 [thread overview]
Message-ID: <yq1murdpd9z.fsf@oracle.com> (raw)
In-Reply-To: <20180926114107.13532-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Wed, 26 Sep 2018 19:41:07 +0800")
Hi Yue Haibing,
> srb_tag = le32_to_cpu(scsiqp->srb_tag);
> - scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
> + scp = scsi_host_find_tag(boardp->shost, srb_tag);
Maybe I'm missing something, but I don't see where in the code
scsiqp->srb_tag is being converted to le32. srb_tag is beyond the memory
accessed by the controller and thus wouldn't need to be little endian.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-10-17 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:41 [PATCH -next] advansys: use correct srb_tag in adv_isr_callback YueHaibing
2018-10-17 1:34 ` Martin K. Petersen [this message]
2018-10-17 12:03 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1murdpd9z.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox