From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, peter.wang@mediatek.com,
tanghuan@vivo.com, liu.song13@zte.com.cn,
quic_nguyenb@quicinc.com, viro@zeniv.linux.org.uk,
huobean@gmail.com, adrian.hunter@intel.com,
can.guo@oss.qualcomm.com, ebiggers@kernel.org,
neil.armstrong@linaro.org,
angelogioacchino.delregno@collabora.com,
quic_narepall@quicinc.com, quic_mnaresh@quicinc.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
nitin.rawat@oss.qualcomm.com, ziqi.chen@oss.qualcomm.com
Subject: Re: [PATCH v3] scsi: ufs: core: Fix data race in CPU latency PM QoS request handling
Date: Wed, 24 Sep 2025 21:59:50 -0400 [thread overview]
Message-ID: <yq1o6qzqol6.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250917094143.88055-1-zhongqiu.han@oss.qualcomm.com> (Zhongqiu Han's message of "Wed, 17 Sep 2025 17:41:43 +0800")
Zhongqiu,
> The cpu_latency_qos_add/remove/update_request interfaces lack internal
> synchronization by design, requiring the caller to ensure thread
> safety. The current implementation relies on the `pm_qos_enabled`
> flag, which is insufficient to prevent concurrent access and cannot
> serve as a proper synchronization mechanism. This has led to data
> races and list corruption issues.
Applied to 6.18/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2025-09-25 2:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 9:41 [PATCH v3] scsi: ufs: core: Fix data race in CPU latency PM QoS request handling Zhongqiu Han
2025-09-17 16:33 ` Bart Van Assche
2025-09-18 3:16 ` Peter Wang (王信友)
2025-09-18 3:51 ` Zhongqiu Han
2025-09-18 3:53 ` Huan Tang
2025-09-25 1:59 ` Martin K. Petersen [this message]
2025-09-30 2:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o6qzqol6.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=ebiggers@kernel.org \
--cc=huobean@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liu.song13@zte.com.cn \
--cc=neil.armstrong@linaro.org \
--cc=nitin.rawat@oss.qualcomm.com \
--cc=peter.wang@mediatek.com \
--cc=quic_mnaresh@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=tanghuan@vivo.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zhongqiu.han@oss.qualcomm.com \
--cc=ziqi.chen@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox