From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yuan Can <yuancan@huawei.com>
Cc: <don.brace@microchip.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <ming.lei@redhat.com>,
<storagedev@microchip.com>, <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: hpsa: Fix possible memory leak in hpsa_init_one()
Date: Wed, 23 Nov 2022 22:45:09 -0500 [thread overview]
Message-ID: <yq1o7sxrp6q.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221122015751.87284-1-yuancan@huawei.com> (Yuan Can's message of "Tue, 22 Nov 2022 01:57:51 +0000")
Yuan,
> The hpda_alloc_ctlr_info() allocates h and its field reply_map,
> however in hpsa_init_one(), if alloc_percpu() failed, the
> hpsa_init_one() jumps to clean1 directly, which frees h and leaks the
> h->reply_map. Fix by calling hpda_free_ctlr_info() to release
> h->replay_map and h instead free h directly.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-24 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 1:57 [PATCH] scsi: hpsa: Fix possible memory leak in hpsa_init_one() Yuan Can
2022-11-23 8:14 ` Ming Lei
2022-11-24 3:45 ` Martin K. Petersen [this message]
2022-12-01 3:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o7sxrp6q.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=don.brace@microchip.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=storagedev@microchip.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox