From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>
Subject: Re: [PATCH] scsi: target: fix prot handling in WRITE SAME 32
Date: Mon, 28 Jun 2021 23:01:09 -0400 [thread overview]
Message-ID: <yq1o8bpl6re.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210616095632.16775-1-d.bogdanov@yadro.com> (Dmitry Bogdanov's message of "Wed, 16 Jun 2021 12:56:32 +0300")
Dmitry,
> WRITE SAME 32 command handling reads WRPROTECT at the wrong offset
> in 1st octet instead of 10th octet.
Instead of twiddling all these offsets I think it would be cleaner to
turn the sbc_setup_write_same() flags[] into an 'unsigned char
protect'. And then fix up sbc_check_prot() to take 'protect' as argument
instead of the full CDB and indexing into that.
Another option would be passing the index but since cdb[0] is only used
for a rare error message I'm not sure it's worth it.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-06-29 3:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:56 [PATCH] scsi: target: fix prot handling in WRITE SAME 32 Dmitry Bogdanov
2021-06-29 3:01 ` Martin K. Petersen [this message]
2021-06-29 16:29 ` Dmitriy Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o8bpl6re.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox