From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chad Dupuis <chad.dupuis@cavium.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com,
QLogic-Storage-Upstream@cavium.com
Subject: Re: [PATCH] bnx2fc: Fix check in SCSI completion handler when reqeust has already timed out.
Date: Tue, 30 Jan 2018 21:26:42 -0500 [thread overview]
Message-ID: <yq1o9lag3vh.fsf@oracle.com> (raw)
In-Reply-To: <20180124160706.32700-1-chad.dupuis@cavium.com> (Chad Dupuis's message of "Wed, 24 Jan 2018 08:07:06 -0800")
Chad,
> When a request times out we set the io_req flag BNX2FC_FLAG_IO_COMPL so
> that if a subsequent completion comes in on that task ID we will ignore
> it. The issue is that in the check for this flag there is a missing
> return so we will continue to process a request which may have already
> been returned to the ownership of the SCSI layer. This can cause
> unpredictable results.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-01-31 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 16:07 [PATCH] bnx2fc: Fix check in SCSI completion handler when reqeust has already timed out Chad Dupuis
2018-01-24 16:12 ` Laurence Oberman
2018-01-31 2:26 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o9lag3vh.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=chad.dupuis@cavium.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox