From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host
Date: Tue, 15 Dec 2015 20:39:54 -0500 [thread overview]
Message-ID: <yq1oadruq6t.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <CACVXFVNJR_uo5GU6+Yx6Qq=hRpS+cDzM=xuwDN1V9OjQCm6aCw@mail.gmail.com> (Ming Lei's message of "Wed, 16 Dec 2015 09:15:05 +0800")
>>>>> "Ming" == Ming Lei <tom.leiming@gmail.com> writes:
Ming> I think it is wrong to set max sectors from OPTIMAL TRANSFER
Ming> LENGTH.
OTL is the preferred size for REQ_TYPE_FS requests as reported by the
device. The intent is to honor that. Your patch clamps the rw_size to
BLK_DEF_MAX_SECTORS which is not correct.
Ming> Also it is ugly to set limits->max_sectors from drivers directly,
Ming> and drivers should have called block helpers to do that.
We're trying to avoid unnecessary accessor functions for the queue
limits. But I will add a sanity check for the page size. And fix up
scsi_debug.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-12-16 1:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 12:01 kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host Eryu Guan
2015-12-15 11:20 ` Eryu Guan
2015-12-15 12:06 ` Ming Lei
2015-12-15 13:06 ` Eryu Guan
2015-12-15 13:27 ` Ming Lei
2015-12-15 16:56 ` Eryu Guan
2015-12-16 1:15 ` Ming Lei
2015-12-16 1:39 ` Martin K. Petersen [this message]
2015-12-15 15:38 ` Ming Lei
2015-12-15 17:16 ` Eryu Guan
2015-12-15 18:29 ` Martin K. Petersen
2015-12-16 1:17 ` Ming Lei
2015-12-16 1:37 ` Martin K. Petersen
2015-12-16 7:25 ` Eryu Guan
2015-12-15 15:38 ` Martin K. Petersen
2016-01-05 11:57 ` Eryu Guan
2016-01-05 23:58 ` Martin K. Petersen
2016-01-06 3:33 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1oadruq6t.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=guaneryu@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).