From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, axboe@kernel.dk, matthew@wil.cx
Subject: Re: [PATCH 1/2] block: add support for discard limits
Date: Mon, 02 Nov 2009 13:18:16 -0500 [thread overview]
Message-ID: <yq1ocnkg593.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4AEF02B0.2060506@panasas.com> (Boaz Harrosh's message of "Mon, 02 Nov 2009 18:02:56 +0200")
>>>>> "Boaz" == Boaz Harrosh <bharrosh@panasas.com> writes:
Boaz> On 11/02/2009 03:29 PM, Martin K. Petersen wrote:
>>
>> With heterogeneous md and dm devices there may not be a meaningful
>> value to put in the discard granularity field. Then what?
>>
Boaz> These alignment masks may only be base-2, no?
Nope. Could be the good old sector 63 offset vs. naturally aligned.
Boaz> If so then the max alignment of all devices will work for any
Boaz> device.
But even then we'd waste space on the array with smaller granularity.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2009-11-02 18:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 15:08 [PATCH 0/2] scsi discard support Christoph Hellwig
2009-10-29 15:08 ` [PATCH 1/2] block: add support for discard limits Christoph Hellwig
2009-10-29 19:06 ` Jens Axboe
2009-10-30 5:03 ` Christoph Hellwig
2009-11-02 12:39 ` Jens Axboe
2009-10-30 3:19 ` Martin K. Petersen
2009-10-30 5:05 ` Christoph Hellwig
2009-11-02 13:29 ` Martin K. Petersen
2009-11-02 15:39 ` James Bottomley
2009-11-02 18:16 ` Martin K. Petersen
2009-11-02 16:02 ` Boaz Harrosh
2009-11-02 18:18 ` Martin K. Petersen [this message]
2009-11-03 15:16 ` Christoph Hellwig
2009-10-29 15:08 ` [PATCH 2/2] sd: add support for WRITE SAME (16) with unmap bit Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ocnkg593.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox