Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, stable@vger.kernel.org,
	Pierre Tomon <pierretom+12@ik.me>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] scsi: sd: Use READ(16) when reading block zero on large capacity disks
Date: Tue, 04 Jun 2024 13:30:23 -0400	[thread overview]
Message-ID: <yq1plswaab1.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <50211dcb-dc40-4bb5-8168-8f102f6bfb5c@acm.org> (Bart Van Assche's message of "Tue, 4 Jun 2024 11:00:05 -0600")


Hi Bart!

> Maybe this is a good opportunity to change 'char' into 'u8'? It seems
> a bit unusual to me to use signed char for a SCSI CDB and a data
> buffer.

It's not signed (-funsigned-char) but I can change it to u8.

Martin

  reply	other threads:[~2024-06-04 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-218890-208809@https.bugzilla.kernel.org/>
     [not found] ` <bug-218890-208809-ISXsODEmWC@https.bugzilla.kernel.org/>
2024-05-30 19:03   ` [Bug 218890] reset SuperSpeed USB device number 2 using xhci_hcd Alan Stern
2024-05-31  1:44     ` Martin K. Petersen
2024-05-31  8:39       ` Pierre Tomon
2024-06-04 12:49         ` Mathias Nyman
2024-06-04 14:45         ` [PATCH] scsi: sd: Use READ(16) when reading block zero on large capacity disks Martin K. Petersen
2024-06-04 14:49           ` Alan Stern
2024-06-04 17:00           ` Bart Van Assche
2024-06-04 17:30             ` Martin K. Petersen [this message]
2024-06-05  2:25             ` [PATCH v2] " Martin K. Petersen
2024-06-05 19:15               ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1plswaab1.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pierretom+12@ik.me \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox