From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: stanley.chu@mediatek.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err()
Date: Sun, 23 Jul 2023 15:27:26 -0400 [thread overview]
Message-ID: <yq1pm4i5syu.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230712064832.44188-1-yang.lee@linux.alibaba.com> (Yang Li's message of "Wed, 12 Jul 2023 14:48:32 +0800")
Yang,
> There is no need to call the dev_err() function directly to print a
> custom message when handling an error from either the platform_get_irq()
> or platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-07-23 19:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 6:48 [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err() Yang Li
2023-07-12 6:51 ` AngeloGioacchino Del Regno
2023-07-13 13:11 ` Sudeep Holla
2023-07-13 13:21 ` Sudeep Holla
2023-07-23 19:27 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pm4i5syu.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=abaci@linux.alibaba.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=stanley.chu@mediatek.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox