From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jack Wang <jinpu.wang@cloud.ionos.com>
Cc: Igor Pylypiv <ipylypiv@google.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vishakha Channapattan <vishakhavc@google.com>,
Akshat Jain <akshatzen@google.com>,
Jolly Shah <jollys@google.com>, Yu Zheng <yuuzheng@google.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: pm80xx: Fix tmf task completion race condition
Date: Mon, 26 Jul 2021 23:19:01 -0400 [thread overview]
Message-ID: <yq1pmv4qwbs.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210707185945.35559-1-ipylypiv@google.com> (Igor Pylypiv's message of "Wed, 7 Jul 2021 11:59:45 -0700")
Jack,
> The tmf timeout timer may trigger at the same time when the response
> from a controller is being handled. When this happens the sas task may
> get freed before the response processing is finished.
>
> Fix this by calling complete() only when SAS_TASK_STATE_DONE is not set.
>
> Similar race condition was fixed in commit b90cd6f2b905
> ("scsi: libsas: fix a race condition when smp task timeout")
Please review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-07-27 3:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 18:59 [PATCH] scsi: pm80xx: Fix tmf task completion race condition Igor Pylypiv
2021-07-27 3:19 ` Martin K. Petersen [this message]
2021-07-27 5:20 ` Jinpu Wang
2021-07-27 5:19 ` Jinpu Wang
2021-07-29 3:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1pmv4qwbs.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=akshatzen@google.com \
--cc=ipylypiv@google.com \
--cc=jejb@linux.ibm.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=jollys@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=vishakhavc@google.com \
--cc=yuuzheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox