From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099D1C32771 for ; Wed, 22 Jan 2020 23:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7E6F24673 for ; Wed, 22 Jan 2020 23:19:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="nVoCBLqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726099AbgAVXTf (ORCPT ); Wed, 22 Jan 2020 18:19:35 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:41998 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgAVXTf (ORCPT ); Wed, 22 Jan 2020 18:19:35 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00MNIosR196451; Wed, 22 Jan 2020 23:19:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=pn8iiw1Er8+rRWCFCDbFsPHRvMaYZbbqVfGUzyvAN/4=; b=nVoCBLqwAaXUzCFxKS6nQ1Yr6XLiMkefpaPS+IDlfJfJOjUbOY62+Jiwq/uWIn1w8jUg pWincsRUB+w619pinu8mw24a9aIRHutexVjkn+lNTIfuCK1kjPOzjKsbeO10mS4rIa86 5x58eeJVSn0+mFzDyo+OztRh9CVvPtgtr6wj8Z2HKPV9S67uzc9lgqtqER5bVJfeNW6C P013tPMtfYgAWeHjroVFbN1hYPw7cOOhlawWIamLXvtEE/+ndgNf6++dTu/ZYpNmkgwo r8V77uicWZal2y53ddusLva/19vLCrIyWECfoUCLj3vgIGHQ21RZnWWMRoDQGzKAOi9k 6A== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2xktnreue6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Jan 2020 23:19:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00MNJKvI148722; Wed, 22 Jan 2020 23:19:28 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2xpq0v3b5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Jan 2020 23:19:25 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00MNI91M015509; Wed, 22 Jan 2020 23:18:10 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 22 Jan 2020 15:18:09 -0800 To: Himanshu Madhani Cc: , , Subject: Re: [PATCH v4] qla2xxx: Fix unbound NVME response length From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200121192710.32314-1-hmadhani@marvell.com> Date: Wed, 22 Jan 2020 18:18:07 -0500 In-Reply-To: <20200121192710.32314-1-hmadhani@marvell.com> (Himanshu Madhani's message of "Tue, 21 Jan 2020 11:27:10 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9508 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=819 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001220194 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9508 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=898 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001220194 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Himanshu, > On certain cases when response length is less than 32, NVME response > data is supplied inline in IOCB. This is indicated by some combination > of state flags. There was an instance when a high, and incorrect, > response length was indicated causing driver to overrun buffers. Fix > this by checking and limiting the response payload length. Applied to 5.5/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering