[PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

[PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

[Michael Kelley (EOSG)]

Increase cmd_per_lun to allow more I/Os in progress per device,
particularly for NVMe's.  The Hyper-V host side can handle the
higher count with no issues.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 drivers/scsi/storvsc_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index f3264c4..6205107 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1657,7 +1657,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
 	.eh_timed_out =		storvsc_eh_timed_out,
 	.slave_alloc =		storvsc_device_alloc,
 	.slave_configure =	storvsc_device_configure,
-	.cmd_per_lun =		255,
+	.cmd_per_lun =		2048,
 	.this_id =		-1,
 	.use_clustering =	ENABLE_CLUSTERING,
 	/* Make sure we dont get a sg segment crosses a page boundary */
-- 
1.8.3.1

Re: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

[Martin K. Petersen]

> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's.  The Hyper-V host side can handle the
> higher count with no issues.

Long/KY/Cathy/Stephen: Please ack/review Michael's patches.

-- 
Martin K. Petersen	Oracle Linux Engineering

RE: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

[KY Srinivasan]

> -----Original Message-----
> From: Michael Kelley (EOSG)
> Sent: Wednesday, January 24, 2018 2:50 PM
> To: KY Srinivasan <kys@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; martin.petersen@oracle.com; Long Li
> <longli@microsoft.com>; jejb@linux.vnet.ibm.com;
> devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Cc: Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>
> Subject: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed
> devices
> 
> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's.  The Hyper-V host side can handle the
> higher count with no issues.
> 
> Signed-off-by: Michael Kelley <mikelley@microsoft.com>

Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>

Thanks,

K. Y
> ---
>  drivers/scsi/storvsc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index f3264c4..6205107 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1657,7 +1657,7 @@ static int storvsc_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *scmnd)
>  	.eh_timed_out =		storvsc_eh_timed_out,
>  	.slave_alloc =		storvsc_device_alloc,
>  	.slave_configure =	storvsc_device_configure,
> -	.cmd_per_lun =		255,
> +	.cmd_per_lun =		2048,
>  	.this_id =		-1,
>  	.use_clustering =	ENABLE_CLUSTERING,
>  	/* Make sure we dont get a sg segment crosses a page boundary */
> --
> 1.8.3.1

Re: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

[Martin K. Petersen]

Michael,

> Increase cmd_per_lun to allow more I/Os in progress per device,
> particularly for NVMe's.  The Hyper-V host side can handle the higher
> count with no issues.

Applied to 4.16/scsi-fixes. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering