From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: lpfc: Convert timers to use timer_setup() Date: Tue, 31 Oct 2017 11:43:06 -0400 Message-ID: References: <20171025100709.GA145055@beast> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:29844 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdJaPnT (ORCPT ); Tue, 31 Oct 2017 11:43:19 -0400 In-Reply-To: <20171025100709.GA145055@beast> (Kees Cook's message of "Wed, 25 Oct 2017 03:07:09 -0700") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Kees Cook Cc: "Martin K. Petersen" , James Smart , Dick Kennedy , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Kees, > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. Looks good to me but since it's a bit gnarly it would be good for James or Dick to take a closer look. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering