From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 2/3] scsi: Protect against buffer possible overflow in scsi_set_sense_information Date: Mon, 13 Jul 2015 20:54:51 -0400 Message-ID: References: <1436697423-20611-1-git-send-email-sagig@mellanox.com> <1436697423-20611-3-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1436697423-20611-3-git-send-email-sagig@mellanox.com> (Sagi Grimberg's message of "Sun, 12 Jul 2015 13:37:02 +0300") Sender: target-devel-owner@vger.kernel.org To: Sagi Grimberg Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , "Martin K. Petersen" , Bart Van Assche , "Nicholas A. Bellinger" , James Bottomley , Tejun Heo List-Id: linux-scsi@vger.kernel.org >>>>> "Sagi" == Sagi Grimberg writes: Sagi> Make sure that the input sense buffer has sufficient length to fit Sagi> the information descriptor (12 additional bytes). Modify Sagi> scsi_set_sense_information to receive the sense buffer length and Sagi> adjust it's callers scsi target and libata. Nitpicking: s/it's/its/ Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering