public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: dgilbert@interlog.com
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	hch@infradead.org, axboe@kernel.dk, matthew@wil.cx,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support
Date: Fri, 30 Oct 2009 00:53:31 -0400	[thread overview]
Message-ID: <yq1pr85scs4.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4AEA6B76.2010303@interlog.com> (Douglas Gilbert's message of "Fri, 30 Oct 2009 00:28:38 -0400")

>>>>> "Doug" == Douglas Gilbert <dgilbert@interlog.com> writes:

Doug> And if both are supported by the logical unit, the patch prefers
Doug> UNMAP?

Yes.

SBC states that if the device reports MAXIMUM UNMAP LBA COUNT > 1 and
MAXIMUM UNMAP DESCRIPTOR COUNT > 1 then the device supports UNMAP.  And
in that case that's what I'll issue.  In all other cases I'll send out
WRITE SAME(16).  I believe that approach is what's currently considered
best practice.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2009-10-30  4:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30  3:30 [RFC] Thin provisioning bits Martin K. Petersen
2009-10-30  3:30 ` [PATCH 1/2] block: Expose discard granularity Martin K. Petersen
2009-10-30  5:07   ` Christoph Hellwig
2009-11-02 13:31     ` Martin K. Petersen
2009-11-03 15:12       ` Christoph Hellwig
2009-11-03 19:08         ` Jens Axboe
2009-10-30  3:30 ` [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-10-30  4:28   ` Douglas Gilbert
2009-10-30  4:53     ` Martin K. Petersen [this message]
2009-10-30 16:02       ` Ric Wheeler
2009-10-30  5:11   ` Christoph Hellwig
2009-11-02 13:32     ` Martin K. Petersen
2009-11-03 15:12       ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2009-11-04  4:25 Thin provisioning update Martin K. Petersen
2009-11-04  4:25 ` [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1pr85scs4.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=dgilbert@interlog.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox